Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(layer): remove link from clipboard button #1135

Merged

Conversation

heitorlessa
Copy link
Contributor

@heitorlessa heitorlessa commented Apr 20, 2022

Which issue number/url will this fix?

Fixes: #1134

Summary

Changes

Please provide a summary of what's being changed

Removes href from clipboard button, so Chrome customers can correctly copy Lambda Layer ARN values.

User experience

Please share what the user experience looks like before and after this change

Gif demonstrating that the text should continue to work, and the clipboard button will no longer be a href

chrome issue gif

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.


View rendered docs/index.md

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 20, 2022
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Apr 20, 2022
@heitorlessa heitorlessa merged commit 7e76868 into aws-powertools:develop Apr 20, 2022
@heitorlessa heitorlessa deleted the docs/fix-clipboard-button branch April 20, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant