Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(parser): Add missing fields for SESEvent #1027

Merged
merged 1 commit into from
Apr 28, 2022
Merged

fix(parser): Add missing fields for SESEvent #1027

merged 1 commit into from
Apr 28, 2022

Conversation

ran-isenberg
Copy link
Contributor

Changes:
Added missing fields, added 3 new recipet type: Bounce, S3 and WorkMail actions
derived from #1025 but had less missing fields.

@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 13, 2022
@github-actions github-actions bot added the bug Something isn't working label Feb 13, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2022 •
edited
Loading

Codecov Report

Merging #1027 (f00939e) into develop (77f86c0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1027   +/-   ##
========================================
  Coverage    99.96%   99.96%           
========================================
  Files          119      119           
  Lines         5364     5384   +20     
  Branches       612      616    +4     
========================================
+ Hits          5362     5382   +20     
  Partials         2        2
Impacted Files Coverage Δ
...bda_powertools/utilities/parser/models/__init__.py 100.00% <ø> (ø)
...s_lambda_powertools/utilities/parser/models/ses.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77f86c0...f00939e. Read the comment docs.

@heitorlessa heitorlessa added revisit-in-3-months Requires more customers feedback before making or revisiting a decision need-customer-feedback Requires more customers feedback before making or revisiting a decision do-not-merge labels Feb 25, 2022
@sthulb
Copy link
Contributor

sthulb commented Apr 28, 2022 •
edited
Loading

Hey @ran-isenberg – I can't find any ref to Bounce or WorkMail in the actions. Got a source for these?

Found them.

@sthulb sthulb merged commit 797a10a into aws-powertools:develop Apr 28, 2022
sthulb added a commit that referenced this pull request Apr 28, 2022
@sthulb
Revert "fix(parser): Add missing fields for SESEvent (#1027)"
895bf8a 
This reverts commit 797a10a.
@sthulb sthulb mentioned this pull request Apr 28, 2022
Merged
sthulb added a commit that referenced this pull request Apr 28, 2022
@sthulb
Revert "fix(parser): Add missing fields for SESEvent (#1027)" (#1190)
31fe45e 
This reverts commit 797a10a.
@sthulb
Copy link
Contributor

sthulb commented Apr 28, 2022

Reverted due to bad tests – I'll retry tomorrow after fixing tests.

@michaelbrewer
Copy link
Contributor

@sthulb @ran-isenberg

Also note that "SesReceiptBounceAction", "SesReceiptWorkmailAction", "SesReceiptS3Action", types has not been validated with integration tests that i could find.

Hence i closed PR #1026 and dialed it down for PR #1025 which does not include these extra event types.

@ran-isenberg
Copy link
Contributor Author

@sthulb what's wrong with the tests?

@michaelbrewer
Copy link
Contributor

I would also try to validate with @jogold who did this for Typescript (PR: DefinitelyTyped/DefinitelyTyped#50031) how to generate test events for this.

@michaelbrewer
Copy link
Contributor

@ran-isenberg - the broken tests was related to how the same event had a change to include dmarcPolicy, so when this was merged into your PR it broken.

@heitorlessa heitorlessa added the pending-release Fix or implementation already in dev waiting to be released label Apr 29, 2022
heitorlessa pushed a commit that referenced this pull request Apr 29, 2022
@sthulb @heitorlessa
revert(parser): Add missing fields for SESEvent (#1027) (#1190)
2656d6b 
This reverts commit 797a10a.
@github-actions
Copy link
Contributor

This is now released under 1.25.10 version!

@github-actions github-actions bot removed the pending-release Fix or implementation already in dev waiting to be released label Apr 29, 2022
@ran-isenberg
Copy link
Contributor Author

ran-isenberg commented Apr 29, 2022 •
edited
Loading

@heitorlessa @sthulb you removed the entire commit but it contained some fields that were missing, not just the new types bounce etc.
I didnt split my pr like @michaelbrewer did.
Now it's not consistent with dataclasses.

@michaelbrewer
Copy link
Contributor

ok hopefully things are not even more confusing :). I will have to verify that these 2 are consistent now.

heitorlessa added a commit to ran-isenberg/aws-lambda-powertools-python that referenced this pull request May 18, 2022
@heitorlessa
Merge branch 'develop' into boto
2a77841 
* develop: (33 commits)
  fix(docs): remove Slack link (aws-powertools#1210)
  docs(roadmap): add new roadmap section (aws-powertools#1204)
  fix(batch): missing space in BatchProcessingError message (aws-powertools#1201)
  fix(batch): docstring fix for success_handler() record parameter (aws-powertools#1202)
  chore(deps): bump email-validator from 1.1.3 to 1.2.1 (aws-powertools#1199)
  docs(layer): upgrade to 1.25.10
  chore: include regression in changelog
  chore: bump to 1.25.10
  feat(parameters): add clear_cache method for providers (aws-powertools#1194)
  chore(ci): changelog pre-generation to fetch tags from origin
  revert(parser): Add missing fields for SESEvent (aws-powertools#1027) (aws-powertools#1190)
  fix(parser): Add missing fields for SESEvent (aws-powertools#1027)
  fix(data-classes): Add missing SES fields and (aws-powertools#1045)
  fix(event_handler): exception_handler to handle ServiceError exceptions (aws-powertools#1160)
  chore(deps-dev): bump flake8-bugbear from 22.1.11 to 22.4.25 (aws-powertools#1156)
  chore(deps-dev): bump mypy from 0.942 to 0.950 (aws-powertools#1162)
  chore(deps-dev): bump flake8-eradicate from 1.2.0 to 1.2.1 (aws-powertools#1158)
  chore(deps): bump github/codeql-action from 1 to 2 (aws-powertools#1154)
  chore(ci): post release on tagged issues too
  fix(event_handler): Allow for event_source support (aws-powertools#1159)
  ...
@ran-isenberg ran-isenberg deleted the ses branch October 23, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working do-not-merge need-customer-feedback Requires more customers feedback before making or revisiting a decision revisit-in-3-months Requires more customers feedback before making or revisiting a decision size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ran-isenberg @codecov-commenter @sthulb @michaelbrewer @heitorlessa