Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal to help with repository #176

Open
acidjazz opened this issue Apr 27, 2023 · 6 comments
Open

Proposal to help with repository #176

acidjazz opened this issue Apr 27, 2023 · 6 comments

Comments

@acidjazz
Copy link

I would like to reach out and offer my help on keeping this repository up to date, tested, and stable. I imagine you are very busy @sapessi but if you'd like to allow me to help I'd be more than glad.

@hohmannr
Copy link
Contributor

Since we rely on this heavily as well, I also offer my help.

@akrylysov
Copy link

If someone is looking for a maintained alternative, which was created before this repo, I'm happy to accept PRs to https://github.com/akrylysov/algnhsa.

@acidjazz
Copy link
Author

acidjazz commented Aug 6, 2023

If someone is looking for a maintained alternative, which was created before this repo, I'm happy to accept PRs to https://github.com/akrylysov/algnhsa.

is there fiber support? i dont see an example

@akrylysov
Copy link

is there fiber support? i dont see an example

As long as fiber implements the http.Handler interface, it should work.

I haven't tried myself, but it seems adaptor.FiberApp is exactly what you need. You can just pass the result of the adaptor.FiberApp(app) call to algnhsa.ListenAndServe.

@acidjazz
Copy link
Author

acidjazz commented Aug 7, 2023

is there fiber support? i dont see an example

As long as fiber implements the http.Handler interface, it should work.

I haven't tried myself, but it seems adaptor.FiberApp is exactly what you need. You can just pass the result of the adaptor.FiberApp(app) call to algnhsa.ListenAndServe.

Can we update the readme w/ an example that I can test?

@akrylysov
Copy link

I just confirmed, algnhsa is compatible with Fiber v2.48.0:

package main

import (
	"github.com/akrylysov/algnhsa"
	"github.com/gofiber/fiber/v2"
	"github.com/gofiber/fiber/v2/middleware/adaptor"
)

func main() {
	app := fiber.New()
	app.Get("/", func(c *fiber.Ctx) error {
		return c.SendString("Hello, World!")
	})
	algnhsa.ListenAndServe(adaptor.FiberApp(app), nil)
}

I'll update README a bit later to reflect this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants