Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is it intended that new copies of MetricContext retain error details #74

Open
awsbillz opened this issue Feb 6, 2022 · 0 comments
Open

Is it intended that new copies of MetricContext retain error details #74

awsbillz opened this issue Feb 6, 2022 · 0 comments
Labels
question Further information is requested

Comments

@awsbillz
Copy link

awsbillz commented Feb 6, 2022

Am using and extending the MetricsLogger and discovered that error details also get copied to fresh MetricsContext objects. Is it the intended behavior for all properties, including error details to be carried forward on new and copied MetricsContext objects?

https://github.com/awslabs/aws-embedded-metrics-python/blob/master/aws_embedded_metrics/logger/metrics_logger.py#L104
https://github.com/awslabs/aws-embedded-metrics-python/blob/master/aws_embedded_metrics/logger/metrics_context.py#L127
@markkuhn markkuhn added the question Further information is requested label Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@awsbillz @markkuhn