Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 463 introduce yamllint to improve code consistency #470

Merged
merged 10 commits into from
Aug 12, 2022
Merged

Fix 463 introduce yamllint to improve code consistency #470

merged 10 commits into from
Aug 12, 2022

Conversation

javydekoning
Copy link
Contributor

Issue #, if available:
#463

Description of changes:

  • Implemented yamllint configuration file.
  • Fixed all yamllint warnings and errors.

To run do: yamllint .

NOTE: this has not been added to CI yet.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@javydekoning javydekoning changed the title Fix 463 introduct yamllint to improve code consistency Fix 463 introduce yamllint to improve code consistency Apr 8, 2022
StewartW
StewartW previously approved these changes Apr 8, 2022
Copy link
Contributor

@StewartW StewartW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!! 🙌

@sbkok sbkok added this to the v3.2.0 milestone May 20, 2022
StewartW
StewartW previously approved these changes May 26, 2022
Copy link
Collaborator

@sbkok sbkok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement, thanks for making these consistent!

.yamllint Outdated Show resolved Hide resolved
.yamllint Outdated Show resolved Hide resolved
.yamllint Outdated Show resolved Hide resolved
.yamllint Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
@javydekoning javydekoning requested a review from sbkok August 11, 2022 14:59
Copy link
Collaborator

@sbkok sbkok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sbkok sbkok merged commit bdae180 into awslabs:master Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants