-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding in ability to define CodeCommit artifact format #389
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this!
A few minor comments, if you could fix those we are good to go.
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/schema_validation.py
Outdated
Show resolved
Hide resolved
..._commit/bootstrap_repository/adf-build/shared/cdk/cdk_stacks/tests/test_pipeline_creation.py
Show resolved
Hide resolved
Co-authored-by: Simon <[email protected]>
…ild/shared/schema_validation.py Co-authored-by: Simon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for following up on the review and adding this feature!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Issue #, if available:
#387
Description of changes:
Added in the ability to set the CodeCommit source provider property for output artifact format
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.