Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding in ability to define CodeCommit artifact format #389

Merged
merged 8 commits into from
Nov 17, 2021

Conversation

StewartW
Copy link
Contributor

Issue #, if available:
#387

Description of changes:
Added in the ability to set the CodeCommit source provider property for output artifact format

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@StewartW StewartW added the enhancement New feature or request label Oct 4, 2021
Copy link
Collaborator

@sbkok sbkok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!
A few minor comments, if you could fix those we are good to go.

sbkok
sbkok previously approved these changes Nov 12, 2021
Copy link
Collaborator

@sbkok sbkok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for following up on the review and adding this feature!

@sbkok sbkok added this to the v3.2.0 milestone Nov 12, 2021
@sbkok sbkok requested a review from deltagarrett November 12, 2021 09:59
Copy link
Collaborator

@thomasmcgannon thomasmcgannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sbkok sbkok merged commit f686367 into awslabs:master Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Support for CODEBUILD_CLONE_REF in Source of deployment map
3 participants