Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Does ADF support nodejs 14? #385

Closed
engrun opened this issue Sep 2, 2021 · 3 comments · Fixed by #376
Closed

Question: Does ADF support nodejs 14? #385

engrun opened this issue Sep 2, 2021 · 3 comments · Fixed by #376
Milestone

Comments

@engrun
Copy link

engrun commented Sep 2, 2021

Context

Trying to use node14 for deploying SAM app.

buildspec.yml

  install:
    runtime-versions:
      python: 3.8
      nodejs: 14

pipeline-definition:

        provider: codebuild
        properties:
          spec_filename: buildspec.yml
          image: STANDARD_5_0

When running the pipeline, this is the relevant logging:

[Container] 2021/09/02 09:50:29 Running command bash adf.sh transform
302 | adf generate parameters...
..
.. an error and a warning related to pip
..
312 | adf package transform...
323 | Building codeuri: ./lib/handlers runtime: nodejs14.x metadata: {'aws:cdk:path': 
..
..
325 | Build Failed
326 | Error: 'nodejs14.x' runtime is not supported

Question
Is this expected behaviour?
Or is this a misconfiguration on my part?

@engrun
Copy link
Author

engrun commented Sep 3, 2021

To answer my own question:
It turns out that ADF does not use the aws-sam-cli that comes with the CodeBuild image.

Resolution:
When changing
aws-sam-cli==1.15.0 to aws-sam-cli==1.27.2

in the file

/aws-deployment-framework-bootstrap/adf-build/shared/requirements.txt

then
sam build completes successfully

(if you want to test this you can change this file in the ADF shared modules bucket directly for a faster feedback-loop)

@sbkok
Copy link
Collaborator

sbkok commented Nov 8, 2021

Thanks @engrun for providing your workaround.

This issue will be resolved with the next release of ADF.
We are working on v3.2.0 that will update the SAM CLI too, so others don't need to manually change these requirements in the future.

I will leave this issue open until the next version of ADF is released.

@sbkok sbkok added this to the v3.2.0 milestone Nov 8, 2021
@sbkok sbkok linked a pull request Nov 8, 2021 that will close this issue
@sbkok
Copy link
Collaborator

sbkok commented Jan 24, 2023

Thank you for your patience. I am happy to inform you that this issue has been resolved in our latest release v3.2.0 just now.
I'm hereby closing this issue. Please open a new issue if you are experiencing any issues with the latest release.

@sbkok sbkok closed this as completed Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants