Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for s2n_prelude.h Changes #299

Merged
merged 13 commits into from
Nov 18, 2024
Merged

Fix for s2n_prelude.h Changes #299

merged 13 commits into from
Nov 18, 2024

Conversation

waahm7
Copy link
Contributor

@waahm7 waahm7 commented Nov 15, 2024

Description of changes:
S2N added a new s2n_prelude.h, which is included in all .c files when building S2N using the compiler flag -include.
See: aws/s2n-tls#4465

Since SwiftPM does not yet support compiler flags, we are defining all the macros from s2n_prelude.h manually. We have also added a CI job to ensure that whenever s2n_prelude.h changes, we can detect and update Package.swift accordingly.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@waahm7 waahm7 changed the title WIP | Latest Submodule Fix for s2n_prelude.h Changes Nov 15, 2024
@waahm7 waahm7 marked this pull request as ready for review November 15, 2024 22:29
Copy link
Contributor

@graebm graebm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hacky, but it works!

@waahm7 waahm7 merged commit 2253531 into main Nov 18, 2024
26 checks passed
@waahm7 waahm7 deleted the cxx-support branch November 18, 2024 17:20
@waahm7 waahm7 mentioned this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants