-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GraalVM updates to extract the shared lib with native image instead of package as resource #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TingDaoK
changed the title
Add extract lib api
GraalVM updates to extract the shared lib with native image instead of package as resource
Sep 4, 2024
DmitriyMusatkin
approved these changes
Sep 6, 2024
graebm
requested changes
Sep 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How would one use this? There's no documentation
graebm
reviewed
Sep 6, 2024
src/main/java/software/amazon/awssdk/crt/internal/GraalVMNativeFeature.java
Show resolved
Hide resolved
src/main/java/software/amazon/awssdk/crt/internal/GraalVMNativeFeature.java
Show resolved
Hide resolved
- move javadoc settings to be global, not just in the "release" profile - move cmake-configure out of the "generate-sources" phase, so it doesn't run during javadoc generation (yay faster iteration)
graebm
reviewed
Sep 11, 2024
graebm
approved these changes
Sep 13, 2024
Co-authored-by: Michael Graeb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
extracting -> writing to temp -> load
every timeDescription of changes:
javadoc
is not working properly as the dependency is not included during runtime. Switch tomvn javadoc:javadoc
to generates the doc, which mvn can figures out the dependency during compile time.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.