Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose operationName for S3 requests #800

Merged
merged 6 commits into from
Jun 21, 2024
Merged

Expose operationName for S3 requests #800

merged 6 commits into from
Jun 21, 2024

Conversation

graebm
Copy link
Contributor

@graebm graebm commented Jun 21, 2024

Issue:
If an S3MetaRequestType.PUT_OBJECT failed, you couldn't tell exactly which S3 operation failed. Was it PutObject? StartMultipartUpload? UploadPart? CompleteMultipartUpload?

Description of changes:

  • Expose S3 operation name in S3FinishedResponseContext
  • Add S3MetaRequestOptions.withOperationName(String), so users sending requests of type S3MetaRequestType.DEFAULT can pass the actual operation name through.
    • You SHOULD set this for DEFAULT requests. It will be required in the very near future
  • aws-lc: AWS-LC-FIPS-2.0.12 -> AWS-LC-FIPS-2.0.13

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants