Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdk diff should indicate if only Output CF description added, then Cloudformation will not update. #778

Closed
ygoodmn opened this issue Sep 26, 2018 · 1 comment · Fixed by #2029 · May be fixed by MechanicalRock/account-reaper#6
Labels
feature-request A feature should be added or improved. package/tools Related to AWS CDK Tools or CLI

Comments

@ygoodmn
Copy link

ygoodmn commented Sep 26, 2018

CDK Version 0.9.0

Enhancement: cdk diff should indicate if only an Ouput Resource was Added, cloudformation will not update.

Steps:

  1. Add only Output Cloud formation description
  2. run cdk deploy
  3. Get Stack was already up-to-date
  4. run cdk diff

Expected:
[+] Added (Output will be updated on next Resource update)

Actual:
+] Added

Example:
From Synth


Outputs:
LoadBalancerArn:
Description: NLB
Value:
Ref: NLB
Export:
Name: 'NLBArn'

From Terminal:


user@ubuntu:~/sms100$ cdk deploy cdk-NLB
Starting deployment of stack cdk-NLB...
Stack was already up-to-date, it has ARN arn:aws:cloudformation:us-west-1:123456:stack/cdk-NLB/01314e0-c15f-11e8-ab9b-50fae8123456 cdk-sms104-NLB

user@ubuntu:~/sms100$ cdk diff cdk-NLB
[+] Added LoadBalancerArn: {"Description":"NLB","Value":{"Ref":"NLB"},"Export":{"Name":{"NLBArn"}}}''

@rix0rrr rix0rrr added the bug This issue is a bug. label Sep 26, 2018
@RomainMuller RomainMuller added enhancement and removed bug This issue is a bug. labels Sep 27, 2018
@rix0rrr rix0rrr added the package/tools Related to AWS CDK Tools or CLI label Nov 7, 2018
@srchase srchase added feature-request A feature should be added or improved. and removed enhancement labels Jan 3, 2019
@hoshitocat
Copy link

I think that will occur exception when stack status is UPDATE_ROLLBACK_COMPLETE.

rix0rrr added a commit that referenced this issue Mar 16, 2019
If only stack Outputs are changed, CloudFormation generates a ChangeSet
that is executable but has 0 changes.

Before, we looked at the amount of changes to say there was nothing to
do, but now we look at the actual change set status to determine
whether it's an empty change set or not.

The effect is that we can now deploy updates even if only Outputs
changed. This becomes very important when the only thing changed
to a stack is an Output got added because a cross-stack reference
was taken by a downstream stack.

Fixes #778.
rix0rrr added a commit that referenced this issue Mar 16, 2019
If only stack Outputs are changed, CloudFormation generates a ChangeSet
that is executable but has 0 changes.

Before, we looked at the amount of changes to say there was nothing to
do, but now we look at the actual change set status to determine
whether it's an empty change set or not.

The effect is that we can now deploy updates even if only Outputs
changed. This becomes very important when the only thing changed
to a stack is an Output got added because a cross-stack reference
was taken by a downstream stack.

Fixes #778.
rix0rrr added a commit that referenced this issue Mar 18, 2019
If only stack Outputs are changed, CloudFormation generates a ChangeSet
that is executable but has 0 changes.

Before, we looked at the amount of changes to say there was nothing to
do, but now we look at the actual change set status to determine
whether it's an empty change set or not.

The effect is that we can now deploy updates even if only Outputs
changed. This becomes very important when the only thing changed
to a stack is an Output got added because a cross-stack reference
was taken by a downstream stack.

Fixes #778.
rix0rrr added a commit to alex-berger/aws-cdk that referenced this issue Mar 19, 2019
If only stack Outputs are changed, CloudFormation generates a ChangeSet
that is executable but has 0 changes.

Before, we looked at the amount of changes to say there was nothing to
do, but now we look at the actual change set status to determine
whether it's an empty change set or not.

The effect is that we can now deploy updates even if only Outputs
changed. This becomes very important when the only thing changed
to a stack is an Output got added because a cross-stack reference
was taken by a downstream stack.

Fixes aws#778.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. package/tools Related to AWS CDK Tools or CLI
Projects
None yet
5 participants