fix(autoscaling): move lifecycle hook targets to their own module #2628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In accordance with new guidelines, we're centralizing cross-service integrations into their own package. In this case, centralizing AutoScaling Lifecycle Hook Targets into `@aws-cdk/aws-autoscaling-hooktargets`. Fixes #2447. BREAKING CHANGE: using a Topic, Queue or Lambda as Lifecycle Hook Target now requires an integration object from the `@aws-cdk/aws-autoscaling-hooktargets` package.
…g-lifecycle-hooks
…g-lifecycle-hooks
eladb
approved these changes
May 24, 2019
| @@ -1,5 +1,3 @@ | |||
| lambda/bundle.zip | |||
There was a problem hiding this comment.
Should we leave this package for another version as we deprecate it?
| constructor(private readonly fn: lambda.IFunction) { | ||
| } | ||
|
|
||
| public bind(lifecycleHook: autoscaling.ILifecycleHook): autoscaling.LifecycleHookTargetProps { |
There was a problem hiding this comment.
I wonder if bind should pass a scope: Construct (sounds like a useful pattern in general).
eladb
approved these changes
May 28, 2019
This was referenced Aug 22, 2019
This was referenced Dec 12, 2019
This was referenced Dec 12, 2019
This was referenced Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In accordance with new guidelines, we're centralizing cross-service
integrations into their own package. In this case, centralizing
AutoScaling Lifecycle Hook Targets into
@aws-cdk/aws-autoscaling-hooktargets.Fixes #2447.
BREAKING CHANGE: using a Topic, Queue or Lambda as Lifecycle Hook
Target now requires an integration
object from the
@aws-cdk/aws-autoscaling-hooktargetspackage.Pull Request Checklist
designfolderBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.