Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codepipeline): no longer allow providing an index when adding a S… #2624

Merged
merged 1 commit into from
May 24, 2019

Conversation

skinny85
Copy link
Contributor

@skinny85 skinny85 commented May 23, 2019

…tage to a Pipeline.

BREAKING CHANGE: the property atIndex has been removed from the StagePlacement interface.


Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
    • Design: For significant features, design document added to design folder
  • Title and Description
    • Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

…tage to a Pipeline.

BREAKING CHANGE: the property atIndex has been removed from the StagePlacement interface.
@skinny85 skinny85 requested a review from a team as a code owner May 23, 2019 21:27
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain the rational in the PR/commit message? Why is it no longer needed?

@skinny85
Copy link
Contributor Author

I removed it at the CodePipeline team's request.

@skinny85 skinny85 merged commit ce39b12 into aws:master May 24, 2019
@skinny85 skinny85 deleted the fix/add-pipeline-stage-index branch May 24, 2019 16:06
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
This was referenced Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants