feat(cdk): support encoding Tokens as numbers #2534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it possible to isolate the |
RomainMuller
approved these changes
May 13, 2019
Numbers can now be encoded into a set of (hugely negative) numbers, and the encoding can be reversed. This allows APIs that take numbers to take lazy values and intrinsics that evaluate to numbers. This change only introduces the capability, it does not use it in any of the construct libraries yet. Fixes #1455.
rix0rrr
force-pushed
the
huijbers/token-number-encoding
branch
from
9559b41
to
8acae0e
Compare
eladb
reviewed
May 13, 2019
| /** | ||
| * Return a special Double value that encodes the given integer | ||
| */ |
There was a problem hiding this comment.
Mention in the docstring that this is used to encode an index to the token map and therefore it's okay that we don't support negative numbers. Also, mention the limit on the number of number tokens we can support.
| * | ||
| * We put the following marker into the top 16 bits (exponent and sign), and | ||
| * use the mantissa part to encode the token index. To save some bit twiddling |
There was a problem hiding this comment.
"encode the index to the token in the token map"
| * Create a unique number representation for this Token and return it | ||
| */ | ||
| public registerNumber(token: Token): number { | ||
| const tokenIndex = this.tokenCounter++; |
There was a problem hiding this comment.
Error if we reached the limit.
eladb
approved these changes
May 13, 2019
This was referenced Aug 22, 2019
This was referenced Dec 12, 2019
This was referenced Dec 13, 2019
This was referenced Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numbers can now be encoded into a set of (hugely negative) numbers,
and the encoding can be reversed.
This allows APIs that take numbers to take lazy values and intrinsics
that evaluate to numbers.
This change only introduces the capability, it does not use it in any
of the construct libraries yet.
Fixes #1455.
Pull Request Checklist
designfolderBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.