Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing readonly service property on LoadBalancedEc2Service #2378

Closed
nathanpeck opened this issue Apr 25, 2019 · 0 comments · Fixed by #2395 · May be fixed by MechanicalRock/account-reaper#6
Closed

Missing readonly service property on LoadBalancedEc2Service #2378

nathanpeck opened this issue Apr 25, 2019 · 0 comments · Fixed by #2395 · May be fixed by MechanicalRock/account-reaper#6
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container

Comments

@nathanpeck
Copy link
Member

nathanpeck commented Apr 25, 2019

The LoadBalancedFargateService construct has a readonly service property which lets you access the underlying service and indirectly its role for doing things like:

this.api = new ecs.LoadBalancedFargateService(this, 'api', { ..removed..  })
table.grantReadWriteData(this.api.service.taskDefinition.taskRole);

However the LoadBalancedEc2Service is missing this property so there is no way for me to access the role of the created service in order to grant it permissions to write to a table.

Expectation would be that the EC2 version of this construct has the same public readonly property that the Fargate one does

@nathanpeck nathanpeck added the gap label Apr 25, 2019
@nathanpeck nathanpeck changed the title Missing service property on LoadBalancedEc2Service Missing readonly service property on LoadBalancedEc2Service Apr 25, 2019
@SoManyHs SoManyHs self-assigned this Apr 29, 2019
@SoManyHs SoManyHs added the @aws-cdk/aws-ecs Related to Amazon Elastic Container label Apr 29, 2019
SoManyHs added a commit to SoManyHs/aws-cdk that referenced this issue Apr 29, 2019
SoManyHs added a commit to SoManyHs/aws-cdk that referenced this issue Apr 29, 2019
SanderKnape pushed a commit to SanderKnape/aws-cdk that referenced this issue May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container
Projects
None yet
2 participants