Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rds): remove Instance class #2081

Merged
merged 2 commits into from
Mar 26, 2019
Merged

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Mar 22, 2019

There was an instance class which was a placeholder, and didn't have any
implementation. Remove to avoid confusing users.

Also update the README to be very explicit that RDS is not
well-supported.


Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
  • Title and Description
    • Change type: title prefixed with fix, feat will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

There was an instance class which was a placeholder, and didn't have any
implementation. Remove to avoid confusing users.

Also update the README to be very explicit that RDS is not
well-supported.
@rix0rrr rix0rrr requested a review from a team as a code owner March 22, 2019 15:38
@@ -2,6 +2,14 @@

The `aws-cdk-rds` package contains Constructs for setting up RDS instances.

> Note: this package is currently quite limited, as the CDK team is focusing
> on other use cases first. If your use case is not in the list below, there is
> no use coming in to the channel to ask "how do I..." because it won't be
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passive aggressive?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting fed up with the same questions over and over again. But yes, this is probably not the best message to put there. Suggestions?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 you can just point to the escape hatches topic and mention that this is not complete yet.

@@ -2,6 +2,14 @@

The `aws-cdk-rds` package contains Constructs for setting up RDS instances.

> Note: this package is currently quite limited, as the CDK team is focusing
> on other use cases first. If your use case is not in the list below, there is
> no use coming in to the channel to ask "how do I..." because it won't be
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 you can just point to the escape hatches topic and mention that this is not complete yet.

@jogold
Copy link
Contributor

jogold commented Mar 24, 2019

FYI I'm working on a PR to add DB instance support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants