Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cfnspec: Revert patch on AWS::ServiceDiscovery::Instance.InstanceAttributes.PrimitiveType #1409

Closed
eladb opened this issue Dec 20, 2018 · 2 comments
Closed

cfnspec: Revert patch on AWS::ServiceDiscovery::Instance.InstanceAttributes.PrimitiveType #1409

eladb opened this issue Dec 20, 2018 · 2 comments
Assignees
@eladb
Labels
closing-soon This issue will automatically close in 4 days unless further comments are made. feature-request A feature should be added or improved. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.

Comments

@eladb
Copy link
Contributor

eladb commented Dec 20, 2018

We requested the primitive type to be fixed in the CFN spec source. Once that's done, we should be able to revert this commit
eladb pushed a commit that referenced this issue Dec 20, 2018
feat: update CloudFormation resources v2.18.0 (#1407)
0f80b56 
New resource types:

* AWS::AmazonMQ::ConfigurationAssociation
* AWS::IoTAnalytics::Channel
* AWS::IoTAnalytics::Dataset
* AWS::IoTAnalytics::Datastore
* AWS::IoTAnalytics::Pipeline

Misc:

* Patch ServiceDiscovery resource "Map" primitive type to "Json" (see #1409)
* Relax namespaces test so we don't have to update it every time we update the spec
* Rewrite the create-missing-libraries script in typescript so it's a bit more robust and mangles names nicely.
@srchase srchase added feature-request A feature should be added or improved. and removed enhancement labels Jan 3, 2019
@SoManyHs
Copy link
Contributor

@eladb What's the status of this? Wondering if it will affect #1804

@rix0rrr
Copy link
Contributor

rix0rrr commented Feb 21, 2019

It probably shouldn't impact your PR. We patch the CloudFormation spec if the documentation disagrees with the published spec. You should not notice a difference downstream.

@NGL321 NGL321 added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Sep 10, 2019
@NGL321 NGL321 added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 10, 2019
@eladb eladb closed this as completed Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eladb eladb

Labels
closing-soon This issue will automatically close in 4 days unless further comments are made. feature-request A feature should be added or improved. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rix0rrr @eladb @srchase @NGL321 @SoManyHs