java: Lambda Code.asset does not recognize jar as a zip file

[thesurlydev]

I attempted to create a Lambda function and passing a path to a jar file to the withCode and got an exception: Asset must be a .zip file or a directory.

The asset validation should pass if the path points to a valid jar file (which is essentially a zip file).

As a workaround I found that by simply renaming the file from app.jar to app.zip gets past the validation.

[eladb]

Are you using lambda.Code.asset(file)?
Can you paste a code snippet?

[thesurlydev]

Sure, here's the snippet:

        Code codeFromLocalPath = Code.asset("/Users/switbe/projects/app/app-0.1.jar");

        Function func = new Function(this, "test-func-cdk", FunctionProps.builder()
            .withCode(codeFromLocalPath)
            .withHandler("com.myorg.MyFunction::handle")
            .withMemorySize(512)
            .withTimeout(60)
            .withRole(role)
            .withRuntime(Runtime.JAVA8)
            .build());

If I rename the jar file to app-0.1.zip, change the asset path above to match and rerun synthesize the validation passes.

[thesurlydev]

Looking at CDK code, a quick fix would be to update the following to also accept jar extension: https://github.com/awslabs/aws-cdk/blob/master/packages/%40aws-cdk/assets/lib/asset.ts#L93

[eladb]

Yes, makes sense. Thanks for reporting, I misread the original description that the problem is that JARs are not supported.

[thesurlydev]

I'll be glad to contribute the fix for this. I'll have a PR in the next couple of days.