-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NLB: NetworkTargetGroup does not depend on NetworkListener #1139
Comments
That's a bug. Thanks |
Ooh, I totally misunderstood what the error report was about. Could you show some of your code please? |
Here's what the load balancer part should look like: |
My source code where the error occurred is general constitution using NetworkLoadBalancer. I think the same error occurs replacing ALB with NLB in the test(integ.lb-awsvpc-nw) you pasted. I think there is a cause in It is another small problem, but also I report that Sorry for my bad english. |
Fix taking a listener dependency for Network Load Balancers. Fixes #1139.
Fix taking a listener dependency for Network Load Balancers. Fixes #1139.
I tried to deploy NLB with ECS Fargate, but I couldn't deploy Service of ECS because the following reason.
I found that NetworkTargetGroup does not to depend on NetworkListener.
In addition, I found not to call
targetGroup.registerListener(this)
in only NLB.https://github.com/awslabs/aws-cdk/blob/6f2569fd51e7b6152830d40b146ff5f2d607e4c2/packages/%40aws-cdk/aws-elasticloadbalancingv2/lib/nlb/network-listener.ts#L69
https://github.com/awslabs/aws-cdk/blob/6f2569fd51e7b6152830d40b146ff5f2d607e4c2/packages/%40aws-cdk/aws-elasticloadbalancingv2/lib/nlb/network-listener.ts#L60
https://github.com/awslabs/aws-cdk/blob/6f2569fd51e7b6152830d40b146ff5f2d607e4c2/packages/%40aws-cdk/aws-elasticloadbalancingv2/lib/shared/base-listener.ts#L38-L43
I think it should call this
registerListener
function as the same way as ALB.https://github.com/awslabs/aws-cdk/blob/6f2569fd51e7b6152830d40b146ff5f2d607e4c2/packages/%40aws-cdk/aws-elasticloadbalancingv2/lib/alb/application-listener.ts#L252-L255
Is this bug?, or is there any reasons in only NLB?
The text was updated successfully, but these errors were encountered: