Skip to content

Commit

Permalink
fix(codebuild): correctly pass the VPC subnet IDs to the Policy State…
Browse files Browse the repository at this point in the history
…ment's condition when using a VPC. (#2506)

Fixes #2335
  • Loading branch information
skinny85 authored May 10, 2019
1 parent eb13741 commit 145da28
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
6 changes: 3 additions & 3 deletions packages/@aws-cdk/aws-codebuild/lib/project.ts
Original file line number Diff line number Diff line change
Expand Up @@ -903,9 +903,9 @@ export class Project extends ProjectBase {
this.addToRolePolicy(new iam.PolicyStatement()
.addResource(`arn:aws:ec2:${Aws.region}:${Aws.accountId}:network-interface/*`)
.addCondition('StringEquals', {
"ec2:Subnet": [
`arn:aws:ec2:${Aws.region}:${Aws.accountId}:subnet/[[subnets]]`
],
"ec2:Subnet": props.vpc
.selectSubnets(props.subnetSelection).subnetIds
.map(si => `arn:aws:ec2:${Aws.region}:${Aws.accountId}:subnet/${si}`),
"ec2:AuthorizedService": "codebuild.amazonaws.com"
})
.addAction('ec2:CreateNetworkInterfacePermission'));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,10 @@
{
"Ref": "AWS::AccountId"
},
":subnet/[[subnets]]"
":subnet/",
{
"Ref": "MyVPCPrivateSubnet1Subnet641543F4"
}
]
]
}
Expand Down

0 comments on commit 145da28

Please sign in to comment.