Build fails, unable to find s2n/unstable/cleanup.h

[keivanh]

Describe the bug

aws-sdk-cpp build fails during building aws-c-io submodule

Regression Issue

• Select this option if this issue appears to be a regression.

Expected Behavior

Build should be compeleted

Current Behavior

[ 20%] Building C object crt/aws-crt-cpp/crt/aws-c-io/CMakeFiles/aws-c-io.dir/source/posix/pipe.c.o
[ 21%] Building C object crt/aws-crt-cpp/crt/aws-c-io/CMakeFiles/aws-c-io.dir/source/posix/shared_library.c.o
[ 21%] Building C object crt/aws-crt-cpp/crt/aws-c-io/CMakeFiles/aws-c-io.dir/source/posix/socket.c.o
[ 21%] Building C object crt/aws-crt-cpp/crt/aws-c-io/CMakeFiles/aws-c-io.dir/source/retry_strategy.c.o
[ 21%] Building C object crt/aws-crt-cpp/crt/aws-c-io/CMakeFiles/aws-c-io.dir/source/s2n/s2n_tls_channel_handler.c.o
/home/user/Development/aws-sdk-cpp/crt/aws-crt-cpp/crt/aws-c-io/source/s2n/s2n_tls_channel_handler.c:27:14: fatal error: s2n/unstable/cleanup.h: No such file or directory
   27 | #    include <s2n/unstable/cleanup.h>
      |              ^~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
gmake[2]: *** [crt/aws-crt-cpp/crt/aws-c-io/CMakeFiles/aws-c-io.dir/build.make:342: crt/aws-crt-cpp/crt/aws-c-io/CMakeFiles/aws-c-io.dir/source/s2n/s2n_tls_channel_handler.c.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:619: crt/aws-crt-cpp/crt/aws-c-io/CMakeFiles/aws-c-io.dir/all] Error 2
gmake: *** [Makefile:136: all] Error 2

Reproduction Steps

git clone --recurse-submodules https://github.com/aws/aws-sdk-cpp
mkdir awsbuild && cd awsbuild
cmake ../aws-sdk-cpp -DCMAKE_BUILD_TYPE=Debug -DCMAKE_INSTALL_PREFIX=/usr/bin -DBUILD_ONLY="s3"
cmake --build . --config=Debug

Possible Solution

This is happening after commit "dc41ddc498c10ebbf69aba7775afa36c8c1910bd" on Oct 10, 2024.

Temporarily workaround:

git checkout 9e1bb08098312e3e36cbdd30073bc6757015c913

Additional Information/Context

Related issue on aws-sdk-cpp

aws-c-io version used

fcb38c8

Compiler and version used

gcc 11.4.0

Operating System and version

Ubuntu 22.04

[jmklix]

aws/aws-sdk-cpp#3203 (comment)

using a minimal docker image in a clean environment works at that tag

FROM public.ecr.aws/amazonlinux/amazonlinux:2023

#Install g++
RUN yum groupinstall "Development Tools" -y

#Install required dependencies
RUN yum install -y curl-devel openssl-devel ninja-build cmake3

# build and install SDK
RUN git clone --branch 1.11.450 --recurse-submodules https://github.com/aws/aws-sdk-cpp && \
    cd aws-sdk-cpp && \
    mkdir build && \
    cd build && \
    cmake -DBUILD_ONLY="s3" -DCMAKE_INSTALL_PREFIX=/sdk-install -DAUTORUN_UNIT_TESTS=OFF .. && \
    cmake --build . && \
    cmake --install .

so this is likely something build environment specific, if you can replicate this in docker to eliminate build environment concerns would be happy to take a look, but looks like in a clean environment it builds as expected.

Can you make sure you're using the latest version of the cpp sdk and let us know if you are still running into any issues.