-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: run ASH image using non-root user #79
Open
climbertjh2
wants to merge
23
commits into
awslabs:main
Choose a base branch
from
climbertjh2:feature/78/run-container-non-root
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: run ASH image using non-root user #79
climbertjh2
wants to merge
23
commits into
awslabs:main
from
climbertjh2:feature/78/run-container-non-root
+91
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We definitely want to "squash and merge" this one - there are a bunch of intermediate commits that are of no value after this is accepted. |
scrt-dev
approved these changes
Apr 29, 2024
scrthq
previously approved these changes
Apr 29, 2024
…rtjh2/automated-security-helper into feature/78/run-container-non-root
climbertjh2
commented
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: 78
Description of changes:
Updated
Dockerfile
to add a user and set that user as part of the container image build.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.