Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency to stable_baseline3 #16

Closed
verdimrc opened this issue Sep 11, 2022 · 0 comments · Fixed by #18
Closed

Remove dependency to stable_baseline3 #16

verdimrc opened this issue Sep 11, 2022 · 0 comments · Fixed by #18

Comments

@verdimrc
Copy link
Contributor

verdimrc commented Sep 11, 2022

Propose to remove stable_baseline3 from requirements.txt, and move the affected implementations out from a2rl to the examples.

stable_baseline3 depends on gym-0.21 which conflicts to the newer version that a2rl requires. The old gym version doesn't come with complete type checks, and still with deprecated or removed gym APIs.

Currently, a2rl requires stable_baseline3 at these places:

  • in data_generator_gym() which is used only in data_properties.ipynb.
  • in the docstring of WhatifWrapper.

In all cases above, the examples still work (fortunately) with a newer gym.

[UPDATE] Alternatively, investigate whether it's possible to switch to mushroom-rl. It supports newer gym, but due to Cython requirement, need to check how easy is installation on ARM and DL1 instances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant