-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jupyter-idle extension #453
Conversation
- Added the package to the {cpu/gpu}.additional_packages_env.in files - Added import test for the jupyter-idle extension package - Built the images successfully and tested the extension on jupyter lab spun up on the image. Results were as expected. - An OSS review and Appsec review has been copleted for this package - pypi : https://pypi.org/project/jupyter-idle/0.1.1/ - conda-forge : https://anaconda.org/conda-forge/jupyter-idle
|
||
ARG MAMBA_DOCKERFILE_ACTIVATE=1 | ||
|
||
CMD ["python", "-c", "import jupyter_idle"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add better tests than this.
I'm assuming that your extension returns a json response. can we at least validate whether the response has the correct keys.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will add a functional test as a follow up later in the week.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a new commit with unit test changes
b6140fe
This reverts commit 99db206.
Issue #, if available:
Description of changes:
Test result
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.