Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bindings: expose ergonomic key logging #4805

Open
jmayclin opened this issue Sep 27, 2024 · 1 comment
Open

bindings: expose ergonomic key logging #4805

jmayclin opened this issue Sep 27, 2024 · 1 comment

Comments

@jmayclin
Copy link
Contributor

Problem:

The bindings expose a key logging callback: set_key_log_callback

However, this method isn't usable without pulling in the raw s2n_tls_sys types because the callback function requires a pointer to the raw s2n-tls connection: s2n_tls_key_log_fn

Solution:

We should expose an ergonomic, safe key log functionality for the rust bindings

@camshaft
Copy link
Contributor

We should probably just move https://github.com/aws/s2n-quic/blob/main/quic/s2n-quic-tls/src/keylog.rs into the s2n-tls crate.

One thing that we should probably fix is making the opened file a static/LazyCell. The way it is right now is each try_open returns a new File handle, which could potentially lead to a mangled file, since we're concurrently writing to it.

@dougch dougch added the s2n-core team label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants