Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ktls: recv app data #4168

Closed
Tracked by #3711
toidiu opened this issue Aug 25, 2023 · 0 comments · Fixed by #4201
Closed
Tracked by #3711

ktls: recv app data #4168

toidiu opened this issue Aug 25, 2023 · 0 comments · Fixed by #4201

Comments

@toidiu
Copy link
Contributor

toidiu commented Aug 25, 2023

main...toidiu:s2n-tls:ak-ktls0_main1 is a possibly a good place to start but this is complicated enough that it warrants a fresh look. Relevant files are s2n_recv.c, and s2n_ktls_io.c. Its probably best to atleast consider #4169 before starting on a design for this.

The logic in tls/s2n_recv.c is quite complicated and I did not have a very clean integration in the sample code above. A cleaner way would probably be to handle the 'keep reading until we have read size_requested or blocked' inside of the ktls_io file.

We should also ignore conn->config->recv_multi_record since with ktls we dont really have control and it might or might not do multi-records. Prob deserves a comment on the API

@toidiu toidiu mentioned this issue Aug 25, 2023
32 tasks
@toidiu toidiu changed the title app ktls recv app data Aug 25, 2023
@toidiu toidiu changed the title ktls recv app data ktls: recv app data Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant