Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ktls: alert/handshake data #4167

Closed
Tracked by #3711
toidiu opened this issue Aug 25, 2023 · 0 comments · Fixed by #4185
Closed
Tracked by #3711

ktls: alert/handshake data #4167

toidiu opened this issue Aug 25, 2023 · 0 comments · Fixed by #4185

Comments

@toidiu
Copy link
Contributor

toidiu commented Aug 25, 2023

This task involves sending alert and handshake record types from ktls. We will not be sending handshake types for the MVP. KeyUpdate support will be added later when TLS1.3 support is added.

Here is a WIP on how alert integration might look like. Relevant files are s2n_shutdown.c, s2n_alerts.c

We want to integrate from s2n_shutdown.c. I added a new method s2n_alerts_get_error_or_close_notify since the existing method s2n_alerts_write_error_or_close_notify wrote a record.

These are all the connection state variables that need to be updated: https://github.com/aws/s2n-tls/pull/4162/files#diff-732fdef032104706c8a36a45efd7c4098fed24bcec6906b78c81b1bfc9e61eaeR298-R325

@toidiu toidiu mentioned this issue Aug 25, 2023
32 tasks
@toidiu toidiu changed the title alert/handshake conn state we need to update ktls: alert/handshake conn state we need to update Aug 25, 2023
@toidiu toidiu changed the title ktls: alert/handshake conn state we need to update ktls: alert/handshake data Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant