Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fix issues after enabling return value conversion diagnostics #3801

Open
camshaft opened this issue Feb 1, 2023 · 0 comments
Open

CI: fix issues after enabling return value conversion diagnostics #3801

camshaft opened this issue Feb 1, 2023 · 0 comments
Labels

Comments

@camshaft
Copy link
Contributor

camshaft commented Feb 1, 2023

Problem:

In #3798 I tried to enable return value diagnostics. Unfortunately, there's a few issues that came up and I probably won't have time to address them.

  • Fuzzing is broken; it doesn't seem to be picking up my feature probe settings
  • CBMC segfaults on several proofs; we should probably open an issue upstream even if we work around it on our end
  • Some PQ code is complaining about conversion; not totally sure what's happening there.

Solution:

Go through each failure in the CI, address it, and get the PR merged

@toidiu toidiu added the s2n-core team label Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants