refactor(s2n-quic-transport): move stream manager behind trait #1786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
force-pushed
the
camshaft/stream-manager-api
branch
from
acba9d8 to
7c265ce
Compare
camshaft
requested review from
maddeleine and
toidiu
and removed request for
toidiu
maddeleine
reviewed
Jun 7, 2023
maddeleine
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
I'm planning on experimenting with optimizing the stream manager a bit and making the endpoint generic over the stream manager interface will make this easier.
Testing:
Since this is just moving the public API to a trait, all of the existing tests show no change in behavior.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.