feat(s2n-quic): Stabilize congestion control provider and allow for custom congestion controllers #1758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ustom congestion controllers
camshaft
previously approved these changes
May 10, 2023
| path_info: congestion_controller::PathInfo, | ||
| ) -> Self::CongestionController { | ||
| MyCongestionController { | ||
| congestion_window: path_info.max_datagram_size as u32, |
There was a problem hiding this comment.
Probably not a big deal since this is a toy example but this essentially means you can only send 1 packet per RTT, right? Maybe we multiply it by 10, similar to cubic?
toidiu
reviewed
May 11, 2023
toidiu
reviewed
May 11, 2023
toidiu
approved these changes
May 11, 2023
camshaft
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change removes the
unstable-provider-congestion-controllerfeature that was previously required to use a congestion controller other than the default. In addition, this change introduces aunstable-congestion-controllerfeature to allow users to implement their own congestion controllers. I've also included an example of implementing a custom congestion controller.Call-outs:
The sealed trait pattern is used to prevent implementation of the
CongestionControllertrait.I believe removing the
unstable-provider-congestion-controllerfeature is not backward compatible, though since it is unstable that is OK.Testing:
Tested via the included example code.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.