feat(s2n-quic-core): add generic IO event loop #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
force-pushed
the
camshaft/generic-event-loop
branch
3 times, most recently
from
69e2671 to
8251445
Compare
This was referenced May 3, 2023
camshaft
force-pushed
the
camshaft/generic-event-loop
branch
from
8251445 to
f376422
Compare
toidiu
previously approved these changes
May 4, 2023
Comment on lines
+66
to
+67
| // TODO use the [pin macro](https://doc.rust-lang.org/std/pin/macro.pin.html) once | ||
| // available in MSRV |
There was a problem hiding this comment.
can you create an issue also. maybe we need a blanket tracking for MSRV related changes and a list of task to do once bumped
camshaft
force-pushed
the
camshaft/generic-event-loop
branch
from
f376422 to
ef32e31
Compare
toidiu
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using the refactors from #1734 and #1733, this PR adds a generic event loop implementation to make it easier to maintain the existing IO providers and develop new ones. I've updated the
io/testingIO provider to use the new event loop and was able to remove quite a bit of code. This event loop will also be used in the new AF_XDP IO provider.Call-outs:
Note that I haven't changed either the tokio or turmoil event loops in this PR, since that will require some additional work to implement the new
RxandTxtraits forplatform/message/Queue. This is tracked in #1746.Testing:
The event loop is being tested through the
io/testingprovider and all of the associated integration tests that use it. I've opened #1745 to track this.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.