refactor(s2n-quic-core): use an event handler for XDP decoding #1732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
force-pushed
the
camshaft/xdp-decoder
branch
2 times, most recently
from
2135c94 to
b89db41
Compare
camshaft
changed the title
camshaft
force-pushed
the
camshaft/xdp-decoder
branch
3 times, most recently
from
56748c1 to
2dcc0f2
Compare
camshaft
changed the title
camshaft
force-pushed
the
camshaft/xdp-decoder
branch
from
2dcc0f2 to
5b17b7c
Compare
toidiu
approved these changes
May 2, 2023
| } | ||
|
|
||
| /// Decodes a path tuple and payload from a raw packet | ||
| #[inline(always)] | ||
| pub fn decode_packet_validator<'a, D: Decoder<'a>, V: Validator>( | ||
| pub fn decode_packet_with_event<'a, D: Decoder<'a>, E: EventHandler>( |
There was a problem hiding this comment.
ahh.. took me a minute to realize that this is replacing Validator and that events are being used for validation now. maybe renaming with_event to with_validation. Non-blocking.
There was a problem hiding this comment.
Yeah I wanted to make it more generic than just validation, since we're also using it for header field extraction (IP, port, ECN, etc.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
While implementing the AF_XDP IO provider, I realized I didn't expose a way to get the ECN value out of the XDP decoding function. I've repurposed the
Validatortrait to be a more genericEventHandlertrait which has callbacks for each of the different types of headers we handle. I've also implemented this trait for thexdp::path::Tupleanddatagram::Headerto make it easy to extract all of the required information for the IO traits.Call-outs:
The latest nightly started complaining about conflicting exports in
inet- each module has aHeaderand does apub use module::*;. I made it so they all explicitly export types that are used in the code base.Testing:
All of the XDP decoder tests should handle this change. I've also updated the BPF programs and checked that they continue to load and pass the kernel verifier.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.