Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix errors #1721

Merged
merged 3 commits into from
Apr 21, 2023
Merged

ci: fix errors #1721

merged 3 commits into from
Apr 21, 2023

Conversation

toidiu
Copy link
Contributor

@toidiu toidiu commented Apr 21, 2023

Description of changes:

Fix some CI errors

Testing:

CI passing

Is this a refactor change? If so, how have you proved that the intended behavior hasn't changed? -->

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@camshaft camshaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the bench is failing due to it pulling the image from main, which was deployed with the bad regex flags.

@toidiu
Copy link
Contributor Author

toidiu commented Apr 21, 2023

@toidiu toidiu marked this pull request as ready for review April 21, 2023 03:05
@camshaft
Copy link
Contributor

Yep you're right. Well either way we can just ignore it for now. Let's get this merged.

@toidiu toidiu merged commit 425862c into main Apr 21, 2023
@toidiu toidiu deleted the ak-test branch April 21, 2023 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants