fix(s2n-quic-xdp): use unix-specific traits for better compat #1710
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
I ran into a couple of incompatibilities with our current MSRV (1.63) and the XDP code. Namely:
std::os
) in a later version. However, the same trait is still available instd::os::unix
so we can just use that since XDP is always going to be Linux-specific.unsafe
blocks in thelibc
macro so I just opted to make the caller responsible for the unsafe block.Sync
andSend
impls, which are safe according to the inline comments.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.