feat(s2n-quic-xdp): add syscall module #1704
Conversation
| return; | ||
| }; | ||
|
|
||
| // the ring sizes need to be a power of 2 |
There was a problem hiding this comment.
should this be enforced in the set_*_ring_size functions?
There was a problem hiding this comment.
It's enforced by the kernel when you call those functions. You get a invalid input error if it's not.
| let status = Command::new("sudo") | ||
| .arg(Path::new("../").join(path)) | ||
| .arg("--nocapture") | ||
| .current_dir("s2n-quic-xdp") | ||
| .env("CAP_NET_RAW_ENABLED", "1") | ||
| .status() | ||
| .expect("failed to run test case"); | ||
| assert!(status.success()); |
There was a problem hiding this comment.
So our CI can support sudo and AF_XDP? Also is this command missing a cargo test? Not sure what its running.
There was a problem hiding this comment.
Yes you can see the CI task is passing with this. It doesn't need a cargo test because it's invoking the test binary directly. Running sudo cargo test makes a mess of permissions and ends up fetching a new registry and recompiling the whole thing.
There was a problem hiding this comment.
WARNING: CAP_NET_RAW capabilities missing; skipping
syscall_test
I dont think its being tested in our CI atm.
There was a problem hiding this comment.
It is. First it tests it without. Then it runs it with.
There was a problem hiding this comment.
There was a problem hiding this comment.
s2n-quic/tools/xdp/xtask/src/ci.rs
Lines 31 to 35 in 7b99879
Description of changes:
This PR adds a
syscallmodule which contains all of the required interactions for AF_XDP sockets. I've tried to link to all of the relevant parts in libxdp. I also implemented a small mmap abstraction that cleans itself up ondropto make it easier to test some of the syscalls.Call-outs:
The syscalls are relatively low level, still. Higher-level abstractions are in the works.
Testing:
I updated the
xtask ciscript to include tests that run undersudo, which has permission to open raw sockets.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.