tests(s2n-quic-core): enable kani for stream try_fit function #1667
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change enables a kani proof for the stream frame
try_fit
function.Testing
Enabling this proof actually found a bug in the test harness that was overly strict on the fit function. Since this code is in a pretty hot path, we could return a more optimized result at the expense of brute-force computation of each possible length, but it would only save at most a byte or 2 (since our lengths are under
2^16
in practice). As such, I've updated the harness to include the logic to consider intentional unoptimal results.What's super interesting is libFuzzer didn't catch this, even after running it for quite some time. On the other hand, kani returns a counter example quite quickly:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.