feat: add experimental turmoil IO provider and example #1663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
force-pushed
the
camshaft/turmoil-provider
branch
from
475d954 to
1c608ba
Compare
mcches
reviewed
Mar 13, 2023
| @@ -0,0 +1,467 @@ | |||
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
There was a problem hiding this comment.
This seems like a great starting point, but it would be great to fill the gaps so we just have tokio io and we can swap turmoil::net for tokio::net and it just works.
There was a problem hiding this comment.
The trickiest part (and why I didn't end up using the tokio provider) is we use some libc syscalls with raw FDs that you wouldn't be able to intercept. But if tokio had an API that reported to us if it was inside of a simulation or not, we could avoid those paths at runtime and have it Just Work™ for applications.
camshaft
force-pushed
the
camshaft/turmoil-provider
branch
from
139b959 to
cc2f939
Compare
camshaft
force-pushed
the
camshaft/turmoil-provider
branch
from
cc2f939 to
b72defd
Compare
toidiu
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change adds an experimental IO provider for turmoil. This allows applications to inject latency and faults into packet transmission and make assertions about behavior.
I've added an example of how an application might use the s2n-quic API to perform this kind of testing.
Testing:
I added a test for the provider, similar to the tokio provider tests. The example can also be executed and show that it correctly integrates.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.