Expose the datagram traits from s2n-quic #1566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you run cargo fmt on this change? The CI is failing because the formatter has a suggestion. |
This allows customer applications to implement their own Receiver/Sender without depending on s2n-quic-core.
Mark-Simulacrum
force-pushed
the
expose-datagram-traits
branch
from
9c57edc to
a00f5e0
Compare
|
Re-formatted. Sorry for missing that in the initial push. |
camshaft
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows customer applications to implement their own Receiver/Sender without depending on s2n-quic-core.
I believe this captures everything needed for these implementations to happen without a s2n-quic-core dependency, but I didn't verify this. Some things that aren't covered by this PR but may be useful to implementors (based on the default impls):
But both of these are directly in the RFC text for QUIC, so it doesn't seem like they have to be separately exposed; users can define their own versions easily.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.