New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compliance snapshot tests are broken in Rust beta #649

Closed

WesleyRosenblum opened this issue May 6, 2021 · 0 comments · Fixed by #1038

Contributor

WesleyRosenblum commented May 6, 2021

Escaping of apostrophes has changed in Rust beta, so the Compliance snapshot tests are failing

rust-lang/rust#83079

311 │- " An internet datagram can be marked "don't fragment." Any internet",
311 │+ " An internet datagram can be marked "don't fragment." Any internet",

The tests are currently disabled: https://github.com/awslabs/s2n-quic/blob/a8d76e5d1a88d8043a02693f41958ecf41f36d29/common/compliance/cargo-compliance/src/specification/ietf.rs#L236-L238

WesleyRosenblum mentioned this issue

Export ConnectionInfo, Format, and LocalId #648

Merged

WesleyRosenblum linked a pull request

that will close this issue

chore: update to Rust 1.53 #1038

Merged

WesleyRosenblum mentioned this issue

chore: update to Rust 1.53 #1038

Merged

WesleyRosenblum closed this as completed in #1038

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment