Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that MTU probing is only enabled on platforms that guarantee the DF bit is set #1739

Open
camshaft opened this issue May 1, 2023 · 1 comment

Comments

@camshaft
Copy link
Contributor

camshaft commented May 1, 2023

Problem:

In #1737, I added the check to lower the max_mtu if the syscall to set the DF bit failed. We should add a test on platforms where this is true to preserve this logic.

Solution:

Add a test for windows and macOS that checks that, even though the application configured a large max_mtu the emitted event says that it's 1200 bytes.

@camshaft
Copy link
Contributor Author

camshaft commented May 4, 2023

Apparently macOS and iOS 11 added support for this so this should include probing for this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant