Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add make build target alongside make apply #2248

Merged
merged 2 commits into from
Aug 3, 2022

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Aug 3, 2022

Fixes #2225

Description

Adds another target for only building the controller and webhook images and pushing them without using helm to update the existing manifests

How was this change tested?

  • Running make build locally
  • Running make apply locally

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

None

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner August 3, 2022 00:36
@netlify
Copy link

netlify bot commented Aug 3, 2022

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 05e9e88
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/62e9c380e29e9900094f8d0a

@jonathan-innis jonathan-innis merged commit 24694bc into aws:main Aug 3, 2022
njtran pushed a commit to njtran/karpenter-provider-aws that referenced this pull request Aug 9, 2022
* Add a make build target used for make apply

* Add details on using building karpenter images solo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add a make target ('build') that runs ko build
2 participants