-
Notifications
You must be signed in to change notification settings - Fork 951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update default value of dnsPolicy
in values.yaml
to Default
#2199
Conversation
✅ Deploy Preview for karpenter-docs-prod canceled.
|
dnsPolicy
in values.yaml
to Default
c1d2bab
to
7f31747
Compare
7f31747
to
f2f24bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Just a note incase this causes an issue for other users: |
Another situation this breaks: running Karpenter on an ipv6-only cluster on a dual-stack node. Using the node's DNS servers, without DNS64, causes Karpenter to attempt connecting to STS using IPv4. Reverting to ClusterFirst causes it to use coredns, with DNS64, so the connections to STS go through NAT64. |
Fixes #2186
Description
Updates the default
dnsPolicy
for thekarpenter-controller
pod spec to beDefault
as opposed toClusterFirst
How was this change tested?
make test
make apply
Does this change impact docs?
Release Note
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.