Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update default value of dnsPolicy in values.yaml to Default #2199

Merged
merged 4 commits into from
Jul 27, 2022

Conversation

jonathan-innis
Copy link
Contributor

Fixes #2186

Description

Updates the default dnsPolicy for the karpenter-controller pod spec to be Default as opposed to ClusterFirst

How was this change tested?

  • make test
  • Manual deployment validation with make apply

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

None

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner July 27, 2022 01:00
@netlify
Copy link

netlify bot commented Jul 27, 2022

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit f2f24bc
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/62e17e4c6fffa60008a0fcc8

@jonathan-innis jonathan-innis changed the title Dns policy fargate chore: update default value of `dnsPolicy Jul 27, 2022
@jonathan-innis jonathan-innis changed the title chore: update default value of `dnsPolicy chore: update default value of dnsPolicy in values.yaml to Default Jul 27, 2022
Makefile Outdated Show resolved Hide resolved
@jonathan-innis jonathan-innis force-pushed the dns-policy-fargate branch 2 times, most recently from c1d2bab to 7f31747 Compare July 27, 2022 18:04
.gitignore Show resolved Hide resolved
Copy link
Contributor

@ellistarn ellistarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@jonathan-innis jonathan-innis merged commit 8d05335 into aws:main Jul 27, 2022
@jonathan-innis jonathan-innis deleted the dns-policy-fargate branch July 27, 2022 19:30
@snorlaX-sleeps
Copy link
Contributor

Just a note incase this causes an issue for other users:
When using a network stack in Kubernetes e.g Istio, Karpenter will fail to start as dnsPolicy: default is connecting to the VPC based DNS servers which don't have any kubernetes services listed.
The istio-proxy needs to connect to the istiod.istio-system.svc which is a kubernetes service and unavailable with the current setting.
The fix is to revert to dnsPolicy: ClusterFirst in the Helm values file

@johngmyers
Copy link

Another situation this breaks: running Karpenter on an ipv6-only cluster on a dual-stack node. Using the node's DNS servers, without DNS64, causes Karpenter to attempt connecting to STS using IPv4. Reverting to ClusterFirst causes it to use coredns, with DNS64, so the connections to STS go through NAT64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use dnsPolicy=Default by default in helm chart
6 participants