Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure cluster state is synced prior to scheduling #2182

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

tzneal
Copy link
Contributor

@tzneal tzneal commented Jul 25, 2022

Fixes #2164

Description
This prevents an issue where we can over-shoot if many nodes are launched.

How was this change tested?

  • Unit testing & deployed to EKS with a sleep call in the updateNode function.

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This prevents an issue where we can over-shoot if many nodes
are launched.

Fixes aws#2164
@netlify
Copy link

netlify bot commented Jul 25, 2022

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit c847785
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/62dea2b15b0e240008421c8e

@tzneal tzneal marked this pull request as ready for review July 25, 2022 14:04
@tzneal tzneal requested a review from a team as a code owner July 25, 2022 14:04
@tzneal tzneal requested a review from suket22 July 25, 2022 14:04
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect number of nodes been provisioned with the batch fleet fix (#2130)
2 participants