Skip to content

Commit

Permalink
docs: Update api_version in helm provider (#2201)
Browse files Browse the repository at this point in the history
* Update api_version in helm provider

The api_version in the 'exec' section of the 'helm' provider was obsolete. From the kubernetes documentation, it should be 'v1beta1' or 'v1'.
The v1alpĥa1 will return the error: "no kind "ExecCredential" is registered for version "client.authentication.k8s.io/v1alpha1" in scheme "pkg/runtime/scheme.go:100"
The aws cli creates a EKS cluster where the 'v1alpha1' was deprecated and will not deploy.

* Update preview directory with change in apiVersion

Applied the proposed change in 0.13.1 for api_version in the helm provider

* Update api_version in helm

Modify api_version to 'v1beta1' in helm and kubectl providers.
AWS cli creates EKS with this configuration version.
So, let's keep in v1beta1 and not jump directly to v1.
Besides, the kubectl provider does not accept 'v1' but only 'v1beta1'

* Update api_version as per in 0.13.1

Forwarding proposed change in 0.13.1 to 0.13.2 (latest at this pushed commit) to keep coherence.
I had not seen that 0.13.2 was the latest when I pushed on 0.13.1
  • Loading branch information
juangascon authored Jul 27, 2022
1 parent bb3ee8e commit 60419cf
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ provider "helm" {
cluster_ca_certificate = base64decode(module.eks.cluster_certificate_authority_data)
exec {
api_version = "client.authentication.k8s.io/v1alpha1"
api_version = "client.authentication.k8s.io/v1beta1"
command = "aws"
args = ["eks", "get-token", "--cluster-name", local.cluster_name]
}
Expand Down Expand Up @@ -355,7 +355,7 @@ provider "kubectl" {
load_config_file = false
exec {
api_version = "client.authentication.k8s.io/v1alpha1"
api_version = "client.authentication.k8s.io/v1beta1"
command = "aws"
args = ["eks", "get-token", "--cluster-name", module.eks.cluster_id]
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ provider "helm" {
cluster_ca_certificate = base64decode(module.eks.cluster_certificate_authority_data)
exec {
api_version = "client.authentication.k8s.io/v1alpha1"
api_version = "client.authentication.k8s.io/v1beta1"
command = "aws"
args = ["eks", "get-token", "--cluster-name", local.cluster_name]
}
Expand Down Expand Up @@ -341,7 +341,7 @@ provider "kubectl" {
load_config_file = false
exec {
api_version = "client.authentication.k8s.io/v1alpha1"
api_version = "client.authentication.k8s.io/v1beta1"
command = "aws"
args = ["eks", "get-token", "--cluster-name", module.eks.cluster_id]
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ provider "helm" {
cluster_ca_certificate = base64decode(module.eks.cluster_certificate_authority_data)
exec {
api_version = "client.authentication.k8s.io/v1alpha1"
api_version = "client.authentication.k8s.io/v1beta1"
command = "aws"
args = ["eks", "get-token", "--cluster-name", local.cluster_name]
}
Expand Down Expand Up @@ -341,7 +341,7 @@ provider "kubectl" {
load_config_file = false
exec {
api_version = "client.authentication.k8s.io/v1alpha1"
api_version = "client.authentication.k8s.io/v1beta1"
command = "aws"
args = ["eks", "get-token", "--cluster-name", module.eks.cluster_id]
}
Expand Down

0 comments on commit 60419cf

Please sign in to comment.