Skip to content

Commit

Permalink
fix: de-prioritize c1 (#2103)
Browse files Browse the repository at this point in the history
C1 has odd #CPU <-> family mapping which can cause it to be preferred
by bin-packing. De-prioritize to prevent this from occurring.
  • Loading branch information
tzneal authored Jul 11, 2022
1 parent 06ccd99 commit 1bb35e4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/cloudprovider/aws/instance.go
Original file line number Diff line number Diff line change
Expand Up @@ -361,8 +361,8 @@ func (p *InstanceProvider) filterInstanceTypes(instanceTypes []cloudprovider.Ins
if !functional.HasAnyPrefix(*it.InstanceType, "m", "c", "r", "a", "t", "i") {
continue
}
// deprioritize 1st/2nd gen burstable and graviton 1
if functional.HasAnyPrefix(*it.InstanceType, "t1", "t2", "a1") {
// deprioritize some older instance types including 1st/2nd gen burstable, compute and graviton
if functional.HasAnyPrefix(*it.InstanceType, "t1", "t2", "a1", "c1") {
continue
}
// deprioritize metal
Expand Down

0 comments on commit 1bb35e4

Please sign in to comment.