Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support custom device plugin resource #308

Closed
lzjqsdd opened this issue Apr 28, 2023 · 3 comments
Closed

support custom device plugin resource #308

lzjqsdd opened this issue Apr 28, 2023 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-design

Comments

@lzjqsdd
Copy link

lzjqsdd commented Apr 28, 2023

Tell us about your request

'Provision' CRD support custom device plugin resource which can be ignored when matching ec2 instances

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?

in my case, pod need mount /dev/fuse. Now we build a device plugin for /dev/fuse, and register example/fuse resource to kubelet, and already deploy a daemonSet for this resource. this case is same like “nvidia.com/gpu” . But karpenter can't identify "example/fuse", and won't privisioning new k8s node.

if karpenter can ignore this custom resource ,and still provisioning new node , the "example/fuse" daemonSet will depoly soon, and pod can be scheduled immediately.

so, i think if karpenter Provisioner CRD can support custom device plugin resource, and ignore this resource when trying to match available ec2 instances.

Are you currently working around this issue?

Now i have to create a leading pod without this "example/fuse" resource. And force karpenter to provisioning new node. Then delete this leading pod when it's running, this means i already got enough resource for real pod. And the real pod which need "example/fuse" can be scheduled soon. this solution seems some kind of weird .

So If karpetner native support custom device plugin resource woluld be best, users just define custom Provisioner for his needed resource.

Additional Context

No response

Attachments

No response

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@lzjqsdd lzjqsdd added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 28, 2023
@jonathan-innis
Copy link
Member

Closing this as a duplicate of #751. Do you mind adding your use-case to that larger issue?

@lzjqsdd
Copy link
Author

lzjqsdd commented May 4, 2023

Closing this as a duplicate of aws/karpenter-core#751. Do you mind adding your use-case to that larger issue?

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-design
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants