fix(jsii): flatten out dependency list #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop deeply nesting dependency packages and their dependencies. All dependencies are now flattened to a single transitive dependency closure. This will save a lot of space and processing power in processing the assembly.
added 3 commits
April 12, 2019 16:48
…n't doing that before!!
…ansitive dependencies. The original reason for including all transitive dependencies was so that the .NET generator could have a full view of transitively inherited interfaces, so it can generate full proxies. Added a test interface to verify that the build succeeds, and it does, so apparently we don't seem to need the transitive deps anymore.
|
Well the build obviously disagrees with what my commit message says but locally it's passing for some reason. |
RomainMuller
approved these changes
Apr 15, 2019
added 4 commits
April 15, 2019 09:35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop deeply nesting dependency packages and their dependencies.
Emphatically go to direct-level dependencies only, no need to list transitive dependencies.
The original reason for including all transitive dependencies was so
that the .NET generator could have a full view of transitively inherited
interfaces, so it can generate full proxies.
Added a test interface to verify that the build succeeds, and it does,
so apparently we don't need them anymore.
@eladb, am I missing anything? This seems too simple to be true. Or did we
just get rid of a vestigial data structure?
Fixes #453.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.