fix(pacmak): don't automatically translate examples without asking #3219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given the current state of example tooling, the existing default was a bad choice. It forces everyone who is publishing jsii packages everywhere to spend CPU cycles to do example parsing and translation which is bound to fail anyway (as the fixtures and compilation directory will probably not be set up for success, and translation must proceed in a single-threaded fashion). The new default is to use translations if they exist, and otherwise don't do translations. * Builds that care (i.e., mostly the CDK build), will be using `rosetta extract` already to be efficient and correct about compilation, and the tablet files will be picked up as usual. * Builds that don't care will get more efficient. BREAKING CHANGES: Pacmak no longer tries to translate examples by default: this feature is now opt-in.
kaizencc
approved these changes
Dec 3, 2021
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the current state of example tooling, the existing default
was a bad choice.
It forces everyone who is publishing jsii packages everywhere to
spend CPU cycles to do example parsing and translation which is
bound to fail anyway (as the fixtures and compilation directory
will probably not be set up for success, and translation
must proceed in a single-threaded fashion).
The new default is to use translations if they exist, and otherwise
don't do translations.
rosetta extractalready to be efficient and correct about compilation, andthe tablet files will be picked up as usual.
BREAKING CHANGES: Pacmak no longer tries to translate examples
by default: this feature is now opt-in.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.