fix(pacmak): Support more than 255 properties for interfaces in Java #3133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansgarm
changed the title
jsteinich
suggested changes
Nov 7, 2021
| this.code.openBlock( | ||
| `protected ${INTERFACE_PROXY_CLASS_NAME}(${constructorArgs})`, | ||
| `protected ${INTERFACE_PROXY_CLASS_NAME}(final ${BUILDER_CLASS_NAME} builder)`, |
There was a problem hiding this comment.
Certainly a bit non-traditional use of a builder, but the alternative would require the fields to be mutable. Does seem fine given that this is an internal class.
…modifier) as proposed in PR review
ansgarm
force-pushed
the
pacmak-java-builder-fix
branch
from
b096517 to
fe0f118
Compare
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
|
@all-contributors add @ansgarm for code and bug |
|
I've put up a pull request to add @ansgarm! 🎉 |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3132
This is a naive approach to fix the problem outlined in #3132 – it should not be user facing and should not break anything (famous last words before CI fails). Happy for any feedback!
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.