fix(rosetta): crashes on outdated tablet files in a package #3119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A package may accidentally (or on purpose) contain a `.jsii.tabl.json` file, containing pretranslated examples. When an assembly is added for snippet discovery, this tablet will be loaded implicitly to save live conversion time. However, if the tablet file is old, or not even a tablet file, this will stop rosetta with an error. Catch that error and continue anyway. Fixes an issue in Construct Hub.
|
The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged. |
otaviomacedo
approved these changes
Nov 4, 2021
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A package may accidentally (or on purpose) contain a
.jsii.tabl.jsonfile, containing pretranslated examples.
When an assembly is added for snippet discovery, this tablet will
be loaded implicitly to save live conversion time.
However, if the tablet file is old, or not even a tablet file, this
will stop rosetta with an error. Catch that error and continue
anyway.
Fixes an issue in Construct Hub.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.